Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: change the dot patterns #6547

Merged
merged 2 commits into from
Jul 16, 2016
Merged

API: change the dot patterns #6547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a203e4
API: change the dot patterns
tacaswell Jun 7, 2016
13b8c91
TST: add test for lw scaling of dash patterns
tacaswell Jul 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/matplotlib/lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _get_dash_pattern(style):
def _scale_dashes(offset, dashes, lw):
if rcParams['_internal.classic_mode']:
return offset, dashes
scale = max(1.0, lw)
scale = max(2.0, lw)
scaled_offset = scaled_dashes = None
if offset is not None:
scaled_offset = offset * scale
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/rcsetup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ def validate_hist_bins(s):
'lines.solid_capstyle': ['projecting', validate_capstyle],
'lines.dashed_pattern': [[2.8, 1.2], validate_nseq_float()],
'lines.dashdot_pattern': [[4.8, 1.2, 0.8, 1.2], validate_nseq_float()],
'lines.dotted_pattern': [[1.2, 0.6], validate_nseq_float()],
'lines.dotted_pattern': [[1.1, 1.1], validate_nseq_float()],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the line above, I expect the second half of the dashdot pattern should match the dot pattern, or if anything, should be even a little more stretched out along the line. The 0.8 can go to 1.2.


# marker props
'markers.fillstyle': ['full', validate_fillstyle],
Expand Down
Binary file added lib/matplotlib/tests/baseline_images/test_lines/scaled_lines.pdf
View file
Open in desktop
Binary file not shown.
Binary file added lib/matplotlib/tests/baseline_images/test_lines/scaled_lines.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.