Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mlab.rec_join. #6577

Merged
merged 1 commit into from Jun 19, 2016
Merged

Fix mlab.rec_join. #6577

merged 1 commit into from Jun 19, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 13, 2016

examples/misc/rec_lab_demo.py was broken on Python3.

Any plans to just deprecate most of mlab? I can see why it's there but nowadays pandas and friends are much more appropriate for this kind of stuff.

`examples/misc/rec_lab_demo.py` was broken on Python3.
@tacaswell
Copy link
Member

Yes, but we do not have any idea what people are actually using. For example the LIGO notebooks used some stuff from mlab (the power spectrum).

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Jun 13, 2016
@anntzer
Copy link
Contributor Author

anntzer commented Jun 13, 2016

Well, won't a standard deprecation cycle be enough?

@WeatherGod
Copy link
Member

This stuff has been in matplotlib for a very long time. We would need a
few cycles for deprecation, and we should be providing clear replacements
in the deprecation notes.

On Mon, Jun 13, 2016 at 2:24 PM, Antony Lee notifications@github.com
wrote:

Well, won't a standard deprecation cycle be enough?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6577 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-OnE_tTXl7CfRMcgOvtA0WLSYpW0ks5qLaBMgaJpZM4Iz_V2
.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 13, 2016

I certainly understand, and wouldn't have suggested it if I didn't find parts of the code that are broken. The alternative would be to improve the coverage, which is so-so right now (this is actually the kind of code for which high coverage could be achieved).

@tacaswell tacaswell merged commit 0d33b1f into matplotlib:master Jun 19, 2016
@anntzer anntzer deleted the fix-mlab-rec-join branch June 20, 2016 01:01
@QuLogic
Copy link
Member

QuLogic commented Oct 15, 2016

Indirectly backported to v2.x as cbec32b via #6868.

@anntzer anntzer mentioned this pull request Oct 16, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants