FIX: handle non-native endian images #6674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cmap='viridis') | ||
|
|
||
| ax1.imshow(Z.astype('<f8'), **kwargs), | ||
| ax2.imshow(Z.astype('>f8'), **kwargs), |
tacaswell
force-pushed
the
fix_imshow_endiannes
branch
from
9d43cdb
to
2b8f4d3
Compare
|
re worked to not use an if statement + a verbose comment. Force-pushed with update. |
In cbook.safe_mask_invalid also ensure that the data is in native byte order. close matplotlib#6671 closes matplotlib#6394
tacaswell
force-pushed
the
fix_imshow_endiannes
branch
from
2b8f4d3
to
e077c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cbook.safe_mask_invalid also ensure that the data is in
native byte order.
close #6671 closes #6394
I can see a case to be made to split this functionality into a separate function, but doing it this way means only having to change the code in one place, not many.