fixed font_manager.is_opentype_cff_font() #6714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`font_manager.is_opentype_cff_font()` gives false result because compares bytes to str. This won't cause trouble in Py2, but in Py3 results in calling `EmbedTTFType3`, and makes impossible to use CFF fonts. With setting the literal to type of bytes, it works fine.
|
Is it possible to get a CFF font on travis? |
|
It is hard to find a free, raw otf file available for download, what I could find is this one: https://github.com/cozy/cozy-files/raw/a8681c82e97339deb8e4c0abda8b98c0b57d3b35/client/app/assets/fonts/maven-pro-light-300.otf |
|
It is not clear to me what the license on that file is (and it does not appear to be in their tree anymore). It looks like https://www.gnu.org/software/freefont/license.html are available on travis (https://github.com/travis-ci/apt-package-whitelist/pull/944/files). I have verified 'by hand' that this works, will put in another PR with a test. |
tacaswell
added a commit
that referenced
this pull request
Jul 12, 2016
FIX: Correctly identify OTF fonts fixed font_manager.is_opentype_cff_font()
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
follow up to matplotlib#6714
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
follow up to matplotlib#6714
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
follow up to matplotlib#6714
QuLogic
modified the milestones:
2.0 (style change major release),
2.0.1 (next bug fix release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font_manager.is_opentype_cff_font()gives false result because compares bytes to str. This won't cause trouble in Py2, but in Py3 results in callingEmbedTTFType3, and makes impossible to use CFF fonts. With setting the literal to type of bytes, it works fine.