Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forget to disconnect callbacks for dragging. #6808

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 21, 2016

Copy-pasted from #6785 (comment):

There's at least another issue with the DraggableBase code: the mouse move callback (._c1) does not get disconnected when .disconnect() is called (I tried explicitly calling .disconnect() to work around the above-mentioned issue, but I then get a crash upon moving the mouse because on_motion becomes invalid).

@tacaswell tacaswell merged commit 3cb79ed into matplotlib:master Jul 22, 2016
@anntzer anntzer deleted the dont-forget-to-disconnect-dragging-callbacks branch July 22, 2016 01:07
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 22, 2016
@QuLogic
Copy link
Member

QuLogic commented Sep 9, 2016

The original ticket is milestoned for 2.x, but this one isn't, or at least hasn't been backported. Maybe it should be?

tacaswell added a commit that referenced this pull request Sep 9, 2016
…ing-callbacks

FIX: Don't forget to disconnect callbacks for dragging.
@tacaswell
Copy link
Member

backported to v2.x as 85f6bfc

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release), 2.0.1 (next bug fix release) Sep 9, 2016
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants