Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cbook.report_memory, which was deleted in d063dee. #6944

Merged
merged 1 commit into from Aug 20, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented Aug 12, 2016

There was no deprecation process, and having something like this
available as an import is very valuable to users suspecting a
memory leak, or simply needing to track memory usage.

There was no deprecation process, and having something like this
available as an import is very valuable to users suspecting a
memory leak, or simply needing to track memory usage.
@efiring efiring added this to the 2.0 (style change major release) milestone Aug 12, 2016
@efiring
Copy link
Member Author

efiring commented Aug 12, 2016

As an example of why we need this, or a good replacement, see #6940.

@tacaswell
Copy link
Member

It looks like the loop from https://github.com/matplotlib/matplotlib/pull/5360/files#diff-84d254616071e10903ac389d05d109deR36 should be exposed as a cbook function as well?

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.0 (style change major release) Aug 13, 2016
@tacaswell
Copy link
Member

re-milestoned as 2.1 because this has only been removed on master (https://github.com/matplotlib/matplotlib/blob/v2.x/lib/matplotlib/cbook.py#L1439)

@efiring
Copy link
Member Author

efiring commented Aug 15, 2016

@tacaswell, yes, it would be nice to have the whole run_memleak_test() function available as an import, but it relies on a python 3.4+ import, and psutil. We could put it in cbook within a try-except block beginning with the tracemalloc and psutil imports.

@tacaswell
Copy link
Member

Merging this as-is as the alternative is much more work than I anticipated due to py3 only imports.

@tacaswell tacaswell merged commit b7b3445 into matplotlib:master Aug 20, 2016
@efiring efiring deleted the restore_report_memory branch October 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants