Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: ticks filtered by Axis, not in Tick.draw #7042

Merged
merged 2 commits into from Sep 6, 2016
Merged

FIX: ticks filtered by Axis, not in Tick.draw #7042

merged 2 commits into from Sep 6, 2016

Conversation

tacaswell
Copy link
Member

Replaces #6647

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Sep 5, 2016
anntzer and others added 2 commits September 5, 2016 15:36
@anntzer @tacaswell
Assume that tickers respect view limits.
bd05136 
Tickers may return positions epsilon-outside of the view limits and we
don't want to drop them.

The filtering of the ticks is done in the `_update_ticks` method of
`mpl.axis.Axis` which adds a 0.5 px or pt extension onto the view limit
to ensure that ticks on the edge are drawn.
@tacaswell
TST: update tests to account for additional ticks
1c2281b
@tacaswell tacaswell force-pushed the assume-ticker-respects-viewlims branch from 92d6573 to 1c2281b Compare September 5, 2016 19:37
@tacaswell tacaswell changed the title Assume ticker respects viewlims ticks filtered by Axis, not in Tick.draw Sep 5, 2016
@tacaswell tacaswell changed the title ticks filtered by Axis, not in Tick.draw FIX: ticks filtered by Axis, not in Tick.draw Sep 5, 2016
@tacaswell
Copy link
Member Author

@anntzer Corrected the tests and re-worded your commit message a bit to add a note about where the tick-in-view-limit filtering is actually accruing.

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2016
@anntzer
Copy link
Contributor

anntzer commented Sep 5, 2016

Thanks for taking over, I've been a bit busy recently.

@efiring efiring merged commit acdf412 into matplotlib:master Sep 6, 2016
@efiring
Copy link
Member

efiring commented Sep 6, 2016

I merged because I didn't see any point in waiting for Appveyor for this one; Travis passed.

efiring added a commit that referenced this pull request Sep 6, 2016
@efiring
Merge pull request #7042 from tacaswell/assume-ticker-respects-viewlims
9bc745c 
FIX: ticks filtered by Axis, not in Tick.draw
@efiring
Copy link
Member

efiring commented Sep 6, 2016

Pushed to v2.x as 9bc745c.

@efiring efiring mentioned this pull request Sep 6, 2016
Closed
@tacaswell tacaswell deleted the assume-ticker-respects-viewlims branch September 6, 2016 00:56
@QuLogic QuLogic mentioned this pull request Sep 6, 2016
Closed
@anntzer anntzer mentioned this pull request Jun 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tacaswell @anntzer @efiring