Minor animation fixes #7058
Merged
Minor animation fixes #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These look like bug-fixes, can this be backported to v2.x? |
|
Looks good to me. Do we want this backported anywhere? |
| @@ -1205,8 +1205,8 @@ def _init_draw(self): | |||
| artist.set_visible(False) | |||
| artist.set_animated(self._blit) | |||
| # Assemble a list of unique axes that need flushing | |||
There was a problem hiding this comment.
I think the comment needs correction
|
I don't see why it couldn't be backported. Would it be better to make this PR against the v2.x branch? |
|
Well, I fixed the comments, but accidentally pushed to master. My bad guys. |
This allows artists without a .axes attribute to work in animations.
The parameter is artists, not frame_info.
dopplershift
force-pushed
the
anim-fixes
branch
from
8239159
to
6962dee
Compare
tacaswell
modified the milestones:
2.0.1 (next bug fix release),
2.1 (next point release)
tacaswell
pushed a commit
that referenced
this pull request
Sep 8, 2016
FIX: Minor animation fixes Also backport 4cb15ef which was accidentally pushed to master
|
backported to v2.x as 2a33d6e Also grabbed the commit pushed to master. |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_figure()instead of.axes.figure)