Minor tab colour fix #7847
Merged
Minor tab colour fix #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Jan 16, 2017
| @@ -260,7 +260,7 @@ def to_hex(c, keep_alpha=False): | |||
| ### Backwards-compatible color-conversion API | |||
|
|
|||
| cnames = CSS4_COLORS | |||
| COLOR_NAMES = {'xkcd': XKCD_COLORS, 'css4': CSS4_COLORS, 'tc': TABLEAU_COLORS} | |||
| COLOR_NAMES = {'xkcd': XKCD_COLORS, 'css4': CSS4_COLORS, 'tab': TABLEAU_COLORS} | |||
There was a problem hiding this comment.
This isn't used internally anymore and is not in any non-rc release. Do we just want to remove it?
There was a problem hiding this comment.
I think you're right; what was this for, anyway?
There was a problem hiding this comment.
Looks like it was removed in #6382, but left for backwards-compatibility. Should we just remove tab here?
There was a problem hiding this comment.
+1 for removing it if we can (but you probably could guess my vote).
There was a problem hiding this comment.
Ah, I see, I didn't look back far enough.
This dictionary was added in matplotlib#5775 sha: 9655f45 (and not yet released) and was removed from internal use by matplotlib#6382 sha: (master) 22a7b95 / (2.x backport) 3281bcd
|
@QuLogic I took the liberty of just removing it. |
tacaswell
approved these changes
Jan 16, 2017
NelleV
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor correction to the prefix in one last location. Also remove a redundant
OrderedDict.