Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop codecov from posting messages #7926

Merged
merged 2 commits into from Jan 24, 2017
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 23, 2017

@QuLogic
Copy link
Member

QuLogic commented Jan 23, 2017

According to the FAQ on the second page, it can be anywhere, so maybe put it in ci/codecov.yml instead of cluttering up the root.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 23, 2017

Good idea.

@codecov-io
Copy link

codecov-io commented Jan 23, 2017

Current coverage is 62.18% (diff: 100%)

Merging #7926 into master will not change coverage

@@             master      #7926   diff @@
==========================================
  Files           175        175          
  Lines         56125      56125          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34901      34901          
  Misses        21224      21224          
  Partials          0          0          

Powered by Codecov. Last update c93142f...8721e7c

@QuLogic
Copy link
Member

QuLogic commented Jan 23, 2017

Err, I hope that's because the file's not on master yet.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 23, 2017

"lol"
(I have no idea, just following the docs... in any case this should be the coverage for the first version, where .codecov.yml was still in root. Let's see what happens now.)

@Carreau
Copy link
Contributor

Carreau commented Jan 23, 2017

I would strongly recommend the codecov browser extension which show the coverage diff directly in GitHub UI. Also it's strange you get coverall commit status but not codecov.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 23, 2017

That is a neat extension!

@Carreau
Copy link
Contributor

Carreau commented Jan 23, 2017

That is a neat extension!

Yeah, I have the not-so-secret wish to have time to write one for vim to highlight the coverage of most recent commit in my gutter.

@QuLogic
Copy link
Member

QuLogic commented Jan 23, 2017

I think codecov is waiting for appveyor; it only posted before because @anntzer force-pushed which triggered an auto-cancel on appveyor.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jan 23, 2017
@phobson phobson changed the title Stop codecov from posting messages [MRG+1] Stop codecov from posting messages Jan 24, 2017
@QuLogic QuLogic changed the title [MRG+1] Stop codecov from posting messages Stop codecov from posting messages Jan 24, 2017
@QuLogic QuLogic merged commit dd4d2ae into matplotlib:master Jan 24, 2017
@QuLogic
Copy link
Member

QuLogic commented Jan 24, 2017

Fingers crossed this works in the future.

@anntzer anntzer deleted the ci-update branch January 24, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants