Fix layout of spectrum_demo.py #8158
Conversation
|
|
|
||
| plt.subplot(3, 2, 4) | ||
| plt.magnitude_spectrum(s, Fs=Fs, scale='dB') | ||
| fig, axx = plt.subplots(3, 2) |
There was a problem hiding this comment.
I see what you're doing here. But I think we should strive for consistency in the examples/gallery.
In my mind that means, for a single axes object:
fig, ax = plt.subplots()And for multiples axes:
fig, axes = plt.subplots(ncols=C, nrows=R)| # plot different spectrum types: | ||
| axx[1, 0].magnitude_spectrum(s, Fs=Fs) | ||
| axx[2, 0].phase_spectrum(s, Fs=Fs) | ||
| axx[0, 1].remove() # don't display empty ax |
There was a problem hiding this comment.
Good points - fixed them.
|
@anntzer I swapped the plots around for aesthetic reasons: The minus signs in the y-axis changes the position of the y-labels. |
|
|
||
| plt.subplot(3, 2, 6) | ||
| plt.phase_spectrum(s, Fs=Fs) | ||
| # plot different spectrum types: |
There was a problem hiding this comment.
might be worth giving them titles / axis labels?
There was a problem hiding this comment.
@vollbier sorry to move the goal post on you.
In addition to Tom's request could you:
- make the figure bigger (add
figsize=(7, 7)to the call tosubplots)
2) make the Magnitude y-axis log-scaled (if that's appropriate for the domain)
There was a problem hiding this comment.
I added titles, but I think it's worthwhile leaving the default axis labels, since it's feature of the spectrum functions.
|
|
||
| plt.subplot(3, 2, 6) | ||
| plt.phase_spectrum(s, Fs=Fs) | ||
| # plot different spectrum types: |
There was a problem hiding this comment.
@vollbier sorry to move the goal post on you.
In addition to Tom's request could you:
- make the figure bigger (add
figsize=(7, 7)to the call tosubplots)
2) make the Magnitude y-axis log-scaled (if that's appropriate for the domain)
phobson
changed the title
|
Thanks @vollbier ! This is so much better! |
QuLogic
changed the title
Fixes eighth entry in issue #7956