FIX: Buffer overflow in banner grabber

matricali · Feb 21, 2024 · 13035dc · 13035dc
1 parent b855a89
commit 13035dc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/detection.c b/src/detection.c
@@ -227,8 +227,8 @@ int detection_detect_ssh(btkg_context_t *ctx, const char *hostname,
 	if (banner_len > 0) {
 		if (banner_len > BANNER_LEN)
 			banner_len = BANNER_LEN;
-		strncpy(banner, buffer, banner_len);
-		banner[banner_len] = 0;
+		strncpy(banner, buffer, banner_len - 1);
+		banner[banner_len - 1] = 0;
 	}
 
 	if (strstr(banner, "SSH-") != banner) {