Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better organise the documentation, document the policy engine, the authorisation process and the scopes #2637

Merged
merged 9 commits into from May 14, 2024

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Apr 18, 2024

This adds a few section to the documentation:

Fixes #2187
Part of #2605

This also reorganises the documentation to have basically 4 parts:

  • A setup guide
  • Big "topics" high level explanations
  • Reference documentation
  • Technical documentation

I also want to add more "how-to" tutorials, really task-oriented, but I'll add some of them in another PR.

Copy link

cloudflare-pages bot commented Apr 18, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e887cd2
Status: ✅  Deploy successful!
Preview URL: https://86efcc62.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-api-docs.matrix-authentication-service-docs.pages.dev

View logs

Copy link

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for adding this detailed documentation

docs/reference/scopes.md Show resolved Hide resolved
docs/reference/scopes.md Outdated Show resolved Hide resolved
@sandhose sandhose changed the title Documentation Better organise the documentation, document the policy engine, the authorisation process and the scopes Apr 30, 2024
@sandhose sandhose marked this pull request as ready for review April 30, 2024 16:23
Copy link
Contributor

@wrjlewis wrjlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nicely organised documentation and easy to read.

@@ -5,7 +5,13 @@ This documentation is intended to give an overview of how the `matrix-authentica
The documentation itself is built using [mdBook](https://rust-lang.github.io/mdBook/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the first sentence in the readme, would it be worth adding what MAS actually is, in a short sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a few words, mostly copied from the repo README 👍

docs/README.md Outdated Show resolved Hide resolved
- [`manage`](./reference/cli/manage.md)
- [`server`](./reference/cli/server.md)
- [`templates`](./reference/cli/templates.md)
- [`doctor`](./reference/cli/doctor.md)

# Development

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the 'Application Services login' be under a section? Feels like a bit of an orphan at the moment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed a bit lonely, its main purpose is to have a link from the README to have a disclaimer on the state of ASes. I think I'll leave it as-is for now

docs/reference/configuration.md Outdated Show resolved Hide resolved
docs/reference/configuration.md Outdated Show resolved Hide resolved
docs/topics/authorization.md Outdated Show resolved Hide resolved
docs/topics/authorization.md Outdated Show resolved Hide resolved
docs/topics/authorization.md Outdated Show resolved Hide resolved
docs/topics/authorization.md Outdated Show resolved Hide resolved
docs/topics/policy.md Outdated Show resolved Hide resolved
sandhose and others added 2 commits May 3, 2024 17:42
@sandhose sandhose merged commit 56d370f into main May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the default policy behaviour around admin scopes
3 participants