Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pointer type annotations for loads/stores #80

Open
simonlindholm opened this issue Apr 28, 2020 · 0 comments
Open

Improve pointer type annotations for loads/stores #80

simonlindholm opened this issue Apr 28, 2020 · 0 comments

Comments

@simonlindholm
Copy link
Collaborator

We currently emit e.g. *(void*)0x1234 = 12.34f;. Naively this is not too hard to fix by changing Type.ptr() to Type.ptr(Type.f32()), but #79 may cause problems, and the pointer may point to a struct, making f32* incorrect.

Perhaps we should focus on just the silly-looking cases like this and not propagate type information further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant