Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msub msubu instruction #252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

UEPuepUEP
Copy link

No description provided.

Copy link
Collaborator

@simonlindholm simonlindholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this (e.g. extending ps2/manual.s), and run ./run_tests.py --overwrite and commit the test expectation?

m2c/arch_mips.py Outdated Show resolved Hide resolved
@simonlindholm
Copy link
Collaborator

(I'm also still interested in whether msub/msubu are actually used in the real world.)

@UEPuepUEP
Copy link
Author

Can you add a test for this (e.g. extending ps2/manual.s), and run ./run_tests.py --overwrite and commit the test expectation?

So would I add msub + msubu to that file or open a new directory?

@simonlindholm
Copy link
Collaborator

If that instruction is available for PS2 it's probably better to add it to that file, or if it's PSP only a new one? It doesn't actually matter much though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants