Fix Bug 506859 - Add name and constructor properties to each of the E…

…rror constructors Patch from Raphel Speyer
matthieu · Jul 28, 2009 · 7408c3b · 7408c3b
1 parent 55fd1ab
commit 7408c3b
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/org/mozilla/javascript/NativeGlobal.java b/src/org/mozilla/javascript/NativeGlobal.java
@@ -144,20 +144,19 @@ public static void init(Context cx, Scriptable scope, boolean sealed) {
         */
         for (int i = 0; i < errorMethods.length; i++) {
             String name = errorMethods[i];
-            Scriptable errorProto = ScriptRuntime.
-                                        newObject(cx, scope, "Error",
+            ScriptableObject errorProto = 
+              (ScriptableObject) ScriptRuntime.newObject(cx, scope, "Error",
                                                   ScriptRuntime.emptyArgs);
             errorProto.put("name", errorProto, name);
-            if (sealed) {
-                if (errorProto instanceof ScriptableObject) {
-                    ((ScriptableObject)errorProto).sealObject();
-                }
-            }
+            errorProto.put("message", errorProto, "");
             IdFunctionObject ctor = new IdFunctionObject(obj, FTAG,
                                                          Id_new_CommonError,
                                                          name, 1, scope);
             ctor.markAsConstructor(errorProto);
+            errorProto.put("constructor", errorProto, ctor);
+            errorProto.setAttributes("constructor", ScriptableObject.DONTENUM);
             if (sealed) {
+                errorProto.sealObject();
                 ctor.sealObject();
             }
             ctor.exportAsScopeProperty();