Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Campaign actions: Add/Remove Do Not Contact #7567

Merged
merged 5 commits into from Jan 28, 2020
Merged

New Campaign actions: Add/Remove Do Not Contact #7567

merged 5 commits into from Jan 28, 2020

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented May 28, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added Add/Remove DNC as campaign actions

image

image

Steps to test this PR:

  1. Load up this PR
  2. Create campaign and add contacts
  3. Set Add Do Not Contact action
  4. See If contacts were marked as DNC
  5. Remove action and add new action: Remove Do Not Contact
  6. See If contacts were unmarked as DNC

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels May 28, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone May 28, 2019
npracht
npracht previously approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great !

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 29, 2019
@npracht npracht mentioned this pull request Jul 26, 2019
Closed
@florentpetitjean
Copy link

Hello,
The Remove Do not contact action doesn't work for contact that unsubscribe from email. Is that normal ? thanks,

@kuzmany
Copy link
Member Author

kuzmany commented Jul 30, 2019

@florentpetitjean you're true.
Last commit should fixed it. Please re-test

@florentpetitjean
Copy link

Tested and it works now

moskoweb
moskoweb approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@moskoweb moskoweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution working perfectly, I tested in some campaigns, and everything went smoothly.

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
@mautibot
Copy link

mautibot commented Oct 3, 2019

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/feature-request-add-action-set-as-do-not-contact-in-campaign-and-form/10314/12

@mautibot
Copy link

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/feature-request-add-action-set-as-do-not-contact-in-campaign-and-form/10314/25

@drimlike
Copy link

+1 to get this feature available asap :)

@npracht npracht modified the milestone: 2.16.0 Jan 23, 2020
moskoweb
moskoweb approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@moskoweb moskoweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using it on some projects and everything is working very well.

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 24, 2020
@npracht npracht added this to the 2.16.0 milestone Jan 24, 2020
@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Jan 24, 2020
@dennisameling
Copy link
Member

Given the fact that multiple people are confirming here that the feature is working is expected, I'm gonna go ahead and merge this PR for the 2.16 release :)

@dennisameling dennisameling merged commit da42338 into mautic:staging Jan 28, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 28, 2020
@dennisameling dennisameling removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 28, 2020
@kuzmany kuzmany mentioned this pull request Feb 13, 2020
Closed
@petebytes petebytes mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskoweb moskoweb moskoweb approved these changes

@dennisameling dennisameling dennisameling approved these changes

@florentpetitjean florentpetitjean florentpetitjean approved these changes

@npracht npracht npracht left review comments

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kuzmany @florentpetitjean @mautibot @drimlike @dennisameling @moskoweb @npracht