Fix for Pillow 2.1.0 and above

[viaregio]

Pillow changed the font rendering (python-pillow/Pillow#285). So I changed the calculation of the text size. Without this fix the text in the captcha is cut off at the bottom with newer Pillow versions.

[mbi]

Awesome, thanks. Will this work with pillow < 2.1.0?

[viaregio]

I have tested the code with PIL version 1.1.7 and Pillow 2.0.0. There are no cut off letters. With Pillow 2.0.0 you get a little extra whitespace below the letters.

[mktums]

Please accept PR, and upload new version to PyPI.
Thank you.

[mbi]

@viaregio @mktums I'm testing right now, I'm getting cut off letters on Pillow 2.2.1, though.

[viaregio]

Interesting, my Pillow version is 2.2.1 also, maybe I should have deactivated the noise filter to get a clearer Image.

return [x + y + z for x, y, z in zip(font.getsize(text), font.getoffset(text), (1, 1))]

could fix this ramaining issue.

[mbi]

Hmm, still not perfect :(

Here is how I'm testing by the way:

CAPTCHA_NOISE_FUNCTIONS = []
CAPTCHA_LETTER_ROTATION = (-30, 30)
CAPTCHA_CHALLENGE_FUNCT = lambda: ('LULUAWAWABBXX!', 'aaaa')

[mbi]

It's mostly the capital W being annoying

CAPTCHA_CHALLENGE_FUNCT = lambda: ('WWWWWWWWWWW!', 'aaaa')

[mktums]

Problem is that size calculates before rotation.

[mbi]

@mktums probably, but that'll work fine in Pillow 2.0 and PIL 1.1.7.

[mktums]

Well, we can't use old Pillow, so problem is still here.

[mktums]

@viaregio

I think it's OK, but doesn't image now seems too big?

[mbi]

@mktums @viaregio is that with Pillow 2.0, Pillow 2.2 or PIL?

EDIT: Im OK with some extra white space, more than I'm ok with truncated letters…

[mktums]

@mbi @viaregio Pillow 2.2.1, will recheck now for fresh installation…

Update: yes, Pillow 2.2.1, clean install, captcha cloned from @viaregio's repo.

[Nihisil]

Hello! How it is going on? When it will be in main branch?

[mbi]

We're quite yet ready to merge this as-is.

[asaji]

For the time being i was able to get it running perfectly fine on Pillow 2.0

pip uninstall Pillow
pip install Pillow==2.0

Live example: http://dermtermsapp.com/register/

[Nihisil]

@asaji captcha doesn't fit with Pillow==2.1+

For Pillow==2.0 all is working very well

[mennanov]

How soon can we expect that fix merged into master and updated at PyPI?

[mbi]

Merged, thank you!