Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #96

Merged
merged 5 commits into from Feb 19, 2023
Merged

Upgrade GitHub Actions #96

merged 5 commits into from Feb 19, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 19, 2023

No description provided.

@Stewori
Copy link
Member

Stewori commented Feb 19, 2023

The broken tests are not due to this PR. We need to pin pytest to a workable version until we can migrate to current pytest properly...

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

Perhaps merge #51 first.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

Or maybe just remove unused imports. ;-)

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

Please reapprove the workflow run so we can see the failures.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #96 (d44360f) into master (4f2062b) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   73.73%   73.69%   -0.04%     
==========================================
  Files          85       85              
  Lines       12783    12783              
==========================================
- Hits         9425     9421       -4     
- Misses       3358     3362       +4     
Impacted Files Coverage Δ
mdp/nodes/convolution_nodes.py 87.75% <0.00%> (-4.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

You gotta love Coveralls... It fails the tests when Coverage decreased (-0.0%)

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

Looks like the current version of pytest works just fine.

@Stewori
Copy link
Member

Stewori commented Feb 19, 2023

Re coveralls:
IMHO, we should not use it in MDP. MDP is mostly in maintenance mode, nowadays. Goal is mainly to keep it working with new pythons and stuff (although I would hope to get the cupy backend working eventually). Anyway, no big test-engineering will take place, so Codecov won't be of much help. Did we opt in to it anyway? Or do we have to opt out?

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

Given your comments, I would ignore coveralls failures unless there is a significant decrease in coverage (like -5%).

Line 29 of .github/workflows/ci.yml is where the opt-in happens. To opt-out, remove the -cov on line 29.

@coveralls
Copy link

coveralls commented Feb 19, 2023

Coverage Status

Coverage: 73.711% (-0.03%) from 73.742% when pulling d44360f on cclauss:patch-1 into 4f2062b on mdp-toolkit:master.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2023

All non-Coveralls tests now pass.

@Stewori
Copy link
Member

Stewori commented Feb 19, 2023

Okay,for simplicity I will accept this now ignoring the coveralls "failures". Thanks for your effort!

@Stewori Stewori merged commit f9c8c51 into mdp-toolkit:master Feb 19, 2023
@Stewori Stewori mentioned this pull request Feb 19, 2023
@cclauss cclauss deleted the patch-1 branch February 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants