New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-test app for sync functionality #1139
Conversation
…ng the gtest framework. Also some updates to be able to build with a C++17 compiler, without breaking compilation under older standards. The main clash with C++17 was std::byte which is not compatible with our usage. Additionally there were a few things that were deprecated and are now removed, eg. auto_ptr and ptr_fun
megasdk_PR SUCCEDED (85) 👍 |
megasdk_PR SUCCEDED (97) 👍 |
I'm having some problems to build MEGAsync with this branch due to conflicts between |
added a couple of tests that use it. Tests also confirm the local sync debris folders are in the correct state.
megasdk_PR SUCCEDED (98) 👍 |
I see cryptopp have made an adjustment for std::byte also, they too have stopped relying on a global definition and defined their own in their own namespace. I see that in version 610 which I've been building against. From their config.h: ```// Originally in global namespace to avoid ambiguity with other byte typedefs. NAMESPACE_BEGIN(CryptoPP) typedef unsigned char byte;``` |
megasdk_PR SUCCEDED (104) 👍 |
megasdk_PR SUCCEDED (105) 👍 |
Added a test app for sync. It's not finished yet but has some useful tests and may be good to have available in other branches. I've used some c++17 features just in that (without affecting the main SDK - mostly std::filesystem) which prompted this next one:
Resolved some issues when building with a c++17 compliant compiler, mainly that it defines std::byte which clashes with the byte we were defining, and probably with others. The main change is removing 'using namespace std' from headers (even inside the mega namespace it still caused clashes). Just 'using std::map' to pull the specific items we need into the mega namespace works pretty well.