Bindings cookbook #120
Open
Bindings cookbook #120
+916
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schinns
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
This is guide is amazing! Thanks @jchavarri. I made some minor suggestions.
| }; | ||
| ``` | ||
|
|
||
| If you know some value may be `undefined` (but not `null`, see next section), |
There was a problem hiding this comment.
Suggested change
| If you know some value may be `undefined` (but not `null`, see next section), | |
| If you know some value may be `undefined` (but not `null`), see next section, |
There was a problem hiding this comment.
I believe this change modifies the meaning. The original meaning was that if the value may be null, then the reader should see next section. After this change that meaning is lost.
There was a problem hiding this comment.
The suggested change as it is definitely does change the meaning.
Perhaps
If you know some value may be `undefined` (but not `null`, see the next section for more on `null`), and if you know...
Co-authored-by: schinns <schinn.ben@gmail.com>
jchavarri
commented
Oct 14, 2023
| }; | ||
| ``` | ||
|
|
||
| If you know some value may be `undefined` (but not `null`, see next section), |
There was a problem hiding this comment.
I believe this change modifies the meaning. The original meaning was that if the value may be null, then the reader should see next section. After this change that meaning is lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rusty-key suggested to include a "cookbook" section in the bindings page, so that users can grep for common JS patterns and map them to bindings.
This PR adds a cookbook at the end of "Communicate with JavaScript" page, based on https://github.com/yawaramin/bucklescript-bindings-cookbook.