Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Minitest instead of MiniTest #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manuelvanrijn
Copy link

@manuelvanrijn manuelvanrijn commented Aug 2, 2023

The rename happened in 5.0, but 5.19.0 started to only define the old alias when ENV["MT_COMPAT"] is defined, which usually is not the case

the rename happened in 5.0, but 5.19.0 started to only define the old alias when ENV["MT_COMPAT"]
is defined, which usually is not the case
@simonneutert
Copy link

@mfpiccolo here's a failing pipeline for you to double check against: https://github.com/simonneutert/papierkram_api_client/actions/runs/5859933192/job/15886957088?pr=56

@jeppeliisberg
Copy link

Just encountered this as well after upgrading to Rails 7.0.7

uninitialized constant MiniTest (NameError) - happens in minispec-metadata-2.0.0 which is a dependency on minitest-vcr.

setting ENV["MT_COMPAT"] to true made it work again (for now)

Mostly added that last part to make it easier for others searching for that specific error and find a temp solution :-)

@simonneutert
Copy link

simonneutert commented Aug 16, 2023

@jeppeliisberg we got it merged there already 🎉

ordinaryzelig/minispec-metadata#18

thank you for sharing, that ENV["MT_COMPAT"] helps ✌️

@go2null
Copy link

go2null commented Dec 19, 2023

opened #29 before seeing this :(

Hopefully it will be merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants