Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias_method_chain. #34

Merged
merged 1 commit into from May 20, 2017
Merged

Remove alias_method_chain. #34

merged 1 commit into from May 20, 2017

Conversation

redhoodie
Copy link

@redhoodie redhoodie commented May 18, 2017

Rails 5 support

See deprecation of alias_method_chain in rails/rails#19434

  • Sorry, this is a bit hack & slash, does not increment version etc.

@mhgbrown mhgbrown merged commit 1ce5cc8 into mhgbrown:master May 20, 2017
@mhgbrown
Copy link
Owner

No problem, thanks for this. When I have time (lol), I can get a proper release ready for Rails 5.

@dlackty
Copy link
Contributor

dlackty commented Jun 26, 2017

@mhgbrown As this was merged, is there any chance to release a new gem version?

@mhgbrown
Copy link
Owner

@dlackty It's definitely on my agenda! I wanted to properly deprecate older things and fix the build error we have going on. If you have any time to help out with those things, would be much appreciated!

@dlackty
Copy link
Contributor

dlackty commented Jun 27, 2017

@mhgbrown Please check #35 and let me know your thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants