Prevent multiple actions from executing

[shendriks-workgrid]

Description

With the current code in adaptivecards-react, both submitAction and executeAction will be executed if both callbacks are passed and a submit action is triggered. This is unexpected behaviour.

This seems to be a bug that slipped in as indicated by the old comment and running executeAction in the switch/case same as the rest of the handlers solves the issue.

Sample App

import React from "react";
import { AdaptiveCard } from "adaptivecards-react";

const payload = {
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5",
    "body": [
        {
            "type": "ActionSet",
            "actions": [
                {
                    "type": "Action.Execute",
                    "title": "Action.Execute"
                },
                {
                    "type": "Action.Submit",
                    "title": "Action.Submit"
                }
            ]
        }
    ]
}

const App = () => {
  // onExecute Handler
  const onExecuteAction = (e) => {
    console.log("Running ExecuteAction");
  };
  // onSubmit Handler
  const onActionSubmit = (e) => {
    console.log("Running onActionSubmit");
  };

  return <AdaptiveCard payload={payload} onExecuteAction={onExecuteAction} onActionSubmit={onActionSubmit}/>;
};

export default App;

Expected behaviour:

• Clicking on Action.Execute should only execute the onExecuteAction
• Clicking on Action.Submit should only execute the onActionSubmit

Actual behaviour:

• Clicking on Action.Execute executes the onExecuteAction
• Clicking on Action.Submit executes the onActionSubmit and onExecuteAction

Microsoft Reviewers: Open in CodeFlow

[ghost]

Hi @shendriks-workgrid. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

[ghost]

Hi @shendriks-workgrid. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

[ghost]

Staleness reset by shendriks-workgrid

[ghost]

Hi @shendriks-workgrid. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

[ghost]

Staleness reset by shendriks-workgrid

[ghost]

Hi @shendriks-workgrid. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

[ghost]

Staleness reset by shendriks-workgrid

[errouthier]

Could we please have someone take a look at this?

[ghost]

Hi @shendriks-workgrid. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

[ghost]

Staleness reset by shendriks-workgrid

[ghost]

Hi @shendriks-workgrid. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.