New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Occlusion Image in AvsCamera #1155
Open
gerritsMSFT
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
gerritsMSFT:patch-4
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−0
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a binary file? CodeFlow and GitHub previews are confused about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's just a normal text file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inx files can't be rendered by GitHub. It sucks. @jasonknichel and/or @NeoAdonis and/or @zlockard : Do we have a support ticket to GitHub to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaveenThum - git in general, and also github, don't like UTF-16 files and INFs are required to be either ASCII or UTF-16 LE with UTF-16 LE greatly preferred. git/github treat UTF-16 files as binary files instead of text files so you don't get a good diff experience. I work around this by having a local clone of the repo and manually using 'git difftool -d <commit ID from parent this PR is based on> <commit ID of latest commit in PR>' to launch my local diff client which can diff UTF-16.
@JakobL-MSFT - I'm not aware of a support ticket about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaveenThum - so for this PR, if you have a local clone of the official driver sample repo, you could go there and do:
git remote add gerritsMSFT https://github.com/gerritsMSFT/Windows-driver-samples
git fetch
git fetch gerritsMSFT
then look at the branch being merged into the sample repo:
and do a git log on there (git log gerritsMSFT/patch-4) to find the commit it was based on, in this case:
commit b968cfb
Author: JakobL-MSFT 110699333+JakobL-MSFT@users.noreply.github.com
Date: Mon Feb 26 08:40:07 2024 -0800
and then run the diff:
git difftool -d b968cfb gerritsMSFT/patch-4
Not a great experience, but it gets you a diff of the UTF-16 files.