Feature/GraphingCalculator initial commit #450
Conversation
| <Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:uap5="http://schemas.microsoft.com/appx/manifest/uap/windows10/5" IgnorableNamespaces="uap uap5 mp"> | ||
| <Identity Name="Microsoft.WindowsCalculator.Dev" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" Version="0.0.0.0" /> | ||
| <Identity Name="Microsoft.WindowsCalculator.Graphing" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" Version="0.0.0.0" /> |
There was a problem hiding this comment.
I think this may fail to build/test in pipelines. Revert?
Same feedback for the change to AppName.
There was a problem hiding this comment.
Depends. Should the branch be always ready to be merged? I didn't figure we would run CI builds for the feature branch, although it sounds like a good idea.
| // C++/WinRT | ||
| #include "winrtHeaders.h" | ||
|
|
||
| #include "Control/Grapher.h" |
There was a problem hiding this comment.
nit: no project headers in the pch
There was a problem hiding this comment.
I can't find an explanation for the technical reason, but there needs to be a project header in the pch in-order for the XAML compiler to generate correct type information. Removing the project header results in:
2>s:\repos\calculator\src\graphcontrol\generated files\xamltypeinfo.g.cpp(164): error C2039: 'GraphControl': is not a member of '`global namespace''
If you look in the Calculator project, the pch contains App.xaml.h. If you make a blank Visual C++ app, the pch contains 'App.xaml.h'. If you look at our other apps, it's the same. I can't find any documentation explaining why.. @jlaanstra, do you know?
joseartrivera
added
the
graphing calculator
Initial PR for the feature/GraphingCalculator feature branch, part of #338.
The feature incorporates a proprietary Microsoft-owned graphing engine to drive graphing experiences in the Windows Calculator app. Due to the private nature of the graphing engine, the source available in the public repo will make use of a mock graphing engine. See README.md for more details.
This PR simply serves as a base for future feature development. As such, the PR will be immediately merged. Feedback on the content of this PR, and on the feature in general, is encouraged. If there is feedback related to the content of this specific PR, please leave comments on the PR page. We will address the comments in future PRs to the feature branch.