Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for small windows in the graphing calculator #803

Merged
merged 5 commits into from Nov 22, 2019
Merged

Added support for small windows in the graphing calculator #803

merged 5 commits into from Nov 22, 2019

Conversation

rudyhuyn
Copy link
Contributor

@rudyhuyn rudyhuyn commented Nov 15, 2019 •
edited

Part of #338

Add support for small windows in the graphing calculator

Description of the changes:

  • Add toggle button to switch between the equation and the graph mode
  • Only display one mode at a time
  • Full support of accessibility
    • high contrast mode
    • Narrator + announcememnt

Also:

  • some code cleaning

TODO:

  • modify the icon once we receive the final assets.

How changes were validated:

  • manually with light and dark theme + high contrast
  • tested with narrator too

@rudyhuyn rudyhuyn changed the title Added support for small windows for the graphing calculator Added support for small windows in the graphing calculator Nov 15, 2019
joseartrivera
joseartrivera requested changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@joseartrivera joseartrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks for working on this, left a few minor comments for you to review.

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated Show resolved Hide resolved
@sanderl sanderl added the graphing calculator Work items related to the graphing calculator feature. label Nov 19, 2019
@ghost ghost removed the needs author feedback label Nov 22, 2019
@joseartrivera joseartrivera merged commit 7ef6eaf into microsoft:feature/GraphingCalculator Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

@sanderl sanderl Awaiting requested review from sanderl

Assignees

@sanderl sanderl

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rudyhuyn @joseartrivera @sanderl