Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphingCalculator Projects to allow official builds #852

Merged
merged 5 commits into from Dec 11, 2019
Merged

Update GraphingCalculator Projects to allow official builds #852

merged 5 commits into from Dec 11, 2019

Conversation

sanderl
Copy link
Contributor

@sanderl sanderl commented Dec 6, 2019

Fixes part of #338 .

Description of the changes:

  • Updated the MockGraphingImpl project to be called GraphingImpl
  • Updated the nuget.config to include the WindowsApps Microsoft feed

How changes were validated:

  • Tested manually

@sanderl sanderl assigned sanderl and mcooley and unassigned sanderl Dec 6, 2019
@sanderl sanderl added the graphing calculator Work items related to the graphing calculator feature. label Dec 6, 2019
mcooley
mcooley requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@mcooley mcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t add non-public NuGet feeds to the public NuGet.config.

Other parts look good.

@ghost ghost added the needs author feedback label Dec 6, 2019
@ghost ghost removed the needs author feedback label Dec 9, 2019
@sanderl sanderl changed the title Update GraphingCalculator Mock and Nuget to allow official builds Update GraphingCalculator Projects to allow official builds Dec 10, 2019
@sanderl sanderl merged commit f593c62 into microsoft:feature/GraphingCalculator Dec 11, 2019
@sanderl sanderl deleted the build-updates branch January 16, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcooley mcooley mcooley approved these changes

Assignees

@mcooley mcooley

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanderl @mcooley