Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graph rendering of inequalities #856

Merged
merged 2 commits into from Dec 9, 2019
Merged

Fix graph rendering of inequalities #856

merged 2 commits into from Dec 9, 2019

Conversation

joseartrivera
Copy link
Contributor

Fixes part of #338

Description of the changes:

  • Use command plotIneq2D instead of plotEq2d when the equation contains an inequality

How changes were validated:

  • Manual test

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Dec 9, 2019
EriWong
EriWong previously approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good and works well. Thanks!

EriWong
EriWong approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joseartrivera joseartrivera merged commit f1bf335 into microsoft:feature/GraphingCalculator Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EriWong EriWong EriWong approved these changes

Assignees

@EriWong EriWong

Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joseartrivera @EriWong