Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some UI bugs in graph mode #862

Merged
merged 5 commits into from Dec 12, 2019
Merged

Fix some UI bugs in graph mode #862

merged 5 commits into from Dec 12, 2019

Conversation

joseartrivera
Copy link
Contributor

Fixes part of #338

Description of the changes:

  • Removes style option when an equation has an error
  • Always displays red border when an equation has an error
  • Fixes alignment issues in KeyGraphFeatures panel
  • Makes all body text copyable in KeyGraphFeatures panel
  • Makes equation box background consistent in KeyGraphFeatures panel
  • Dot color when tracing an equation now matches the color of the line
  • Coordinates for trace pop-up rounds to 1 decimal for now
  • Fixes Graph control not getting focus on Active Trace button click
  • Removes tool tip from Active Trace Cursor when not near an equation line

How changes were validated:

  • Manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Dec 12, 2019
rudyhuyn
rudyhuyn reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@rudyhuyn rudyhuyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this PR! I let some (very) NIT comments, let me know if you have questions!

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml Show resolved Hide resolved
@joseartrivera joseartrivera merged commit 2a0637e into microsoft:feature/GraphingCalculator Dec 12, 2019
@rudyhuyn
Copy link
Contributor

Perfect!!!! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudyhuyn rudyhuyn rudyhuyn approved these changes

Assignees
No one assigned
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joseartrivera @rudyhuyn