Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update equation colors #885

Merged
merged 6 commits into from Jan 6, 2020
Merged

Update equation colors #885

merged 6 commits into from Jan 6, 2020

Conversation

joseartrivera
Copy link
Contributor

@joseartrivera joseartrivera commented Dec 19, 2019 •
edited

Fixes part of #338.

Description of the changes:

  • Updates equation colors and order of assignment
  • Fixes KGF header background/margin
  • Change error icon to warning
  • Other style clean up

How changes were validated:

  • manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Dec 19, 2019
EriWong
EriWong previously approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@EriWong EriWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rudyhuyn rudyhuyn self-requested a review December 19, 2019 21:35
rudyhuyn
rudyhuyn suggested changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@rudyhuyn rudyhuyn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of that! But I'm afraid we will have some issues with High Contrast, I will test as soon as my PC will finish its update

src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Outdated Show resolved Hide resolved
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp Outdated Show resolved Hide resolved
@ghost ghost removed the needs author feedback label Dec 19, 2019
@rudyhuyn
Copy link
Contributor

rudyhuyn commented Jan 6, 2020

Great job!!! Thank you Pepe!

@rudyhuyn rudyhuyn merged commit 3592b3d into microsoft:feature/GraphingCalculator Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudyhuyn rudyhuyn rudyhuyn approved these changes

@EriWong EriWong EriWong left review comments

Assignees
No one assigned
Labels
graphing calculator Work items related to the graphing calculator feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joseartrivera @rudyhuyn @EriWong