This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Expose TypeScript version in public API #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
suggested changes
Dec 6, 2018
There was a problem hiding this comment.
It makes sense to add a getVersion method, but perhaps that method can be generated automatically when we import a new TypeScript version...
This is a clean way to do it, but it has the side-effect of bringing in >1MB of code in the main thread to simply get the version...
We could write here a placeholder getVersion kind of like:
getVersion: function() { return /*TSVERSION*/"1.2.3"/*TSVERSION*/; }
We could then adapt the import script to always replace that string with the current TS version...
| @@ -9,6 +9,7 @@ import * as mode from './tsMode'; | |||
| import Emitter = monaco.Emitter; | |||
| import IEvent = monaco.IEvent; | |||
| import IDisposable = monaco.IDisposable; | |||
| import { getVersion } from './languageFeatures'; | |||
There was a problem hiding this comment.
This ends up dragging the entire TS compiler to get loaded into the main thread.
|
Done via #31 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in microsoft/monaco-editor#1047.