-
Notifications
You must be signed in to change notification settings - Fork 3.3k
custom allreduce cuda kernel #20703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
custom allreduce cuda kernel #20703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ead5e90
to
9ba3637
Compare
yuslepukhin
reviewed
May 22, 2024
yuslepukhin
reviewed
May 22, 2024
orttraining/orttraining/core/optimizer/compute_optimizer/padding_elimination.cc
Outdated
Show resolved
Hide resolved
yuslepukhin
reviewed
May 22, 2024
yuslepukhin
reviewed
May 22, 2024
yuslepukhin
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
yuslepukhin
reviewed
May 22, 2024
tianleiwu
reviewed
May 23, 2024
tianleiwu
reviewed
May 23, 2024
tianleiwu
reviewed
May 23, 2024
tianleiwu
previously approved these changes
May 28, 2024
yuslepukhin
reviewed
Jun 4, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
reviewed
Jun 7, 2024
yuslepukhin
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, try use allocator in cuda ep instead of cudaMalloc. |
tianleiwu
approved these changes
Jun 13, 2024
snnn
approved these changes
Jun 13, 2024
will have a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conditionally route to custom AllReduce kernel when buffer size and gpu numbers meet certain requirements. Otherwise, keep using NCCL's AllReduce.
Motivation and Context