Skip to content

custom allreduce cuda kernel #20703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 13, 2024
Merged

custom allreduce cuda kernel #20703

merged 24 commits into from
Jun 13, 2024

Conversation

wangyems
Copy link
Contributor

@wangyems wangyems commented May 16, 2024

Description

Conditionally route to custom AllReduce kernel when buffer size and gpu numbers meet certain requirements. Otherwise, keep using NCCL's AllReduce.

Motivation and Context

@wangyems wangyems marked this pull request as ready for review May 17, 2024 04:22
@wangyems wangyems requested a review from a team May 17, 2024 21:32
@wangyems wangyems force-pushed the wangye/custom_reduce branch from ead5e90 to 9ba3637 Compare May 21, 2024 04:20
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

tianleiwu
tianleiwu previously approved these changes May 28, 2024
@wangyems wangyems requested a review from yuslepukhin June 6, 2024 02:36
@wangyems wangyems requested a review from yuslepukhin June 12, 2024 17:10
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tianleiwu
Copy link
Contributor

If possible, try use allocator in cuda ep instead of cudaMalloc.

@wangyems wangyems merged commit f35dd14 into main Jun 13, 2024
95 of 96 checks passed
@wangyems wangyems deleted the wangye/custom_reduce branch June 13, 2024 18:09
@wangyems
Copy link
Contributor Author

If possible, try use allocator in cuda ep instead of cudaMalloc.

will have a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants