Use consistent handler defaults in docs and samples (#2451)

microsoft · Apr 2, 2024 · 83c3607 · 83c3607
1 parent fc9929f
commit 83c3607
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/docs/docfx/articles/direct-forwarding.md b/docs/docfx/articles/direct-forwarding.md
@@ -58,12 +58,13 @@ builder.Services.AddHttpForwarder();
 var app = builder.Build();
 
 // Configure our own HttpMessageInvoker for outbound calls for proxy operations
-var httpClient = new HttpMessageInvoker(new SocketsHttpHandler()
+var httpClient = new HttpMessageInvoker(new SocketsHttpHandler
 {
     UseProxy = false,
     AllowAutoRedirect = false,
     AutomaticDecompression = DecompressionMethods.None,
     UseCookies = false,
+    EnableMultipleHttp2Connections = true,
     ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
     ConnectTimeout = TimeSpan.FromSeconds(15),
 });

diff --git a/docs/docfx/articles/http-client-config.md b/docs/docfx/articles/http-client-config.md
@@ -205,6 +205,7 @@ new SocketsHttpHandler
     AllowAutoRedirect = false,
     AutomaticDecompression = DecompressionMethods.None,
     UseCookies = false,
+    EnableMultipleHttp2Connections = true,
     ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
     ConnectTimeout = TimeSpan.FromSeconds(15),
 };
@@ -227,7 +228,9 @@ public class CustomForwarderHttpClientFactory : IForwarderHttpClientFactory
             AllowAutoRedirect = false,
             AutomaticDecompression = DecompressionMethods.None,
             UseCookies = false,
-            ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current)
+            EnableMultipleHttp2Connections = true,
+            ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
+            ConnectTimeout = TimeSpan.FromSeconds(15),
         };
 
         return new HttpMessageInvoker(handler, disposeHandler: true);

diff --git a/samples/ReverseProxy.Direct.Sample/Program.cs b/samples/ReverseProxy.Direct.Sample/Program.cs
@@ -20,12 +20,13 @@
 var app = builder.Build();
 
 // Configure our own HttpMessageInvoker for outbound calls for proxy operations
-var httpClient = new HttpMessageInvoker(new SocketsHttpHandler()
+var httpClient = new HttpMessageInvoker(new SocketsHttpHandler
 {
     UseProxy = false,
     AllowAutoRedirect = false,
     AutomaticDecompression = DecompressionMethods.None,
     UseCookies = false,
+    EnableMultipleHttp2Connections = true,
     ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
     ConnectTimeout = TimeSpan.FromSeconds(15),
 });

diff --git a/src/ReverseProxy/Forwarder/ForwarderHttpClientFactory.cs b/src/ReverseProxy/Forwarder/ForwarderHttpClientFactory.cs
@@ -47,6 +47,7 @@ public HttpMessageInvoker CreateClient(ForwarderHttpClientContext context)
             AllowAutoRedirect = false,
             AutomaticDecompression = DecompressionMethods.None,
             UseCookies = false,
+            EnableMultipleHttp2Connections = true,
             ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
             ConnectTimeout = TimeSpan.FromSeconds(15),
 

diff --git a/testassets/ReverseProxy.Direct/Program.cs b/testassets/ReverseProxy.Direct/Program.cs
@@ -36,12 +36,13 @@
 
 var app = builder.Build();
 
-var httpClient = new HttpMessageInvoker(new SocketsHttpHandler()
+var httpClient = new HttpMessageInvoker(new SocketsHttpHandler
 {
     UseProxy = false,
     AllowAutoRedirect = false,
     AutomaticDecompression = DecompressionMethods.None,
     UseCookies = false,
+    EnableMultipleHttp2Connections = true,
     ActivityHeadersPropagator = new ReverseProxyPropagator(DistributedContextPropagator.Current),
     ConnectTimeout = TimeSpan.FromSeconds(15),
 });