Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous test assert #2123

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

MihaZupan
Copy link
Member

Hit in #2122

This condition doesn't add value to the test and is also wrong in a race - the thread pool is free to run the HttpClient continuations first, before completing the destinationTask.

@MihaZupan MihaZupan added this to the YARP 2.x milestone May 5, 2023
@MihaZupan MihaZupan requested a review from Tratcher as a code owner May 5, 2023 17:00
@MihaZupan MihaZupan self-assigned this May 5, 2023
@MihaZupan MihaZupan enabled auto-merge (squash) May 5, 2023 17:03
@MihaZupan MihaZupan merged commit 9575319 into microsoft:main May 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants