Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress status update fixes #2136

Merged

Conversation

specialforest
Copy link
Member

  • Updates samples with required permissions and ingress controller options.
  • Adds code documentation for required options.
  • Fixes case when the ingress controller updates statuses of ingresses not belonging to the controller.

This should address #2018. Also refactors changes from #1953 to avoid future errors.

@specialforest
Copy link
Member Author

Dockerfiles Build failed with unrelated error:

RUN curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --jsonfile global.json
#11 18.78 curl: (56) OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 32
...
#21 0.080 /bin/sh: 1: /root/.dotnet/dotnet: not found

Is there a way to re-run checks without making a dummy commit?

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants