Turn off a bunch of optional features in the benchmark #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ | |||
| "profiles": { | |||
| "BenchmarkApp": { | |||
| "commandName": "Project", | |||
| "commandLineArgs": "--urls http://localhost:5000 --clusterUrls http://localhost:10010", | |||
| "commandLineArgs": "--urls http://localhost:5000 --clusterUrls http://httpbin.org", | |||
There was a problem hiding this comment.
Do we want to commit that?
There was a problem hiding this comment.
We already use httpbin in a few sample projects.
I find it easier to test with since you only have to start the proxy project instead of the test server as well.
There was a problem hiding this comment.
Do you see any other problems with the change?
benjaminpetit
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips logic such as ASP.NET's auth middlewares, routing, .... Also skips some optional features like the
X-Forwardedheaders being added by default.This way it more closely matches what we do in the proxy-httpclient scenario: https://github.com/aspnet/Benchmarks/blob/main/src/BenchmarksApps/HttpClient/Proxy/Program.cs
Net effect a is ~17 % RPS bump on the basic h1-h1 scenario.