Verify the platform as quickly as possible #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saibamen
approved these changes
Feb 12, 2024
|
Good idea. I'll move this in my (bigger) PR too. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Closing due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the platform check to the beginning of the script, rather than somewhere in the middle.
This prepares for the possibility of adding a GitHub workflow to test behavior on Linux / macOS platforms, to confirm that the script reports that it doesn't support those platforms (rather than checking the
$__SUDO_TESTand$SUDOEXEvariables first and potentially reporting an error message for those checks instead).