Skip to content

Commit

Permalink
some trivial wording nits
Browse files Browse the repository at this point in the history
  • Loading branch information
zadjii-msft committed Feb 23, 2021
1 parent 6e354e9 commit 05d48ca
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
13 changes: 6 additions & 7 deletions src/cascadia/TerminalSettingsEditor/Actions.xaml
Expand Up @@ -38,8 +38,7 @@ the MIT License. See LICENSE in the project root for license information. -->
<!-- This HorizontalContentAlignment="Stretch" is important
to make sure it takes the entire width of the line -->
<ListViewItem HorizontalContentAlignment="Stretch"
AutomationProperties.Name="{x:Bind Name, Mode=OneWay}"
AutomationProperties.AcceleratorKey="{x:Bind KeyChordText, Mode=OneWay}">
AutomationProperties.Name="{x:Bind Name, Mode=OneWay}">

<Grid HorizontalAlignment="Stretch" ColumnSpacing="8" >
<Grid.ColumnDefinitions>
Expand All @@ -49,7 +48,7 @@ the MIT License. See LICENSE in the project root for license information. -->
<!-- command label -->
<ColumnDefinition Width="*"/>
<!-- key chord -->
<ColumnDefinition Width="16"/>
<ColumnDefinition Width="32"/>
<!-- gutter for scrollbar -->
</Grid.ColumnDefinitions>

Expand Down Expand Up @@ -77,8 +76,7 @@ the MIT License. See LICENSE in the project root for license information. -->

<TextBlock Style="{ThemeResource KeyChordTextBlockStyle}"
FontSize="12"
Text="{x:Bind KeyChordText, Mode=OneWay}"
AutomationProperties.AccessibilityView="Raw" />
Text="{x:Bind KeyChordText, Mode=OneWay}" />

This comment has been minimized.

Copy link
@DHowett

DHowett Feb 23, 2021

Member

gotta make sure that the border being Raw doesn't make this not work. I suspect it will work fine, but we do want to test.

This comment has been minimized.

Copy link
@zadjii-msft

zadjii-msft Feb 23, 2021

Author Member

Alright well we're learning about narrator today then 😛 yea, this didn't work as expected. I'm messing with it now.

</Border>
</Grid>
</ListViewItem>
Expand Down Expand Up @@ -174,10 +172,11 @@ the MIT License. See LICENSE in the project root for license information. -->

<ListView HorizontalAlignment="Stretch"
VerticalAlignment="Stretch"
SelectionMode="Single"
SelectionMode="None"
IsItemClickEnabled="False"
CanReorderItems="False"
AllowDrop="False"
ItemsSource="{x:Bind FilteredActions}"
ItemsSource="{x:Bind FilteredActions, Mode=OneWay}"
ItemTemplate="{StaticResource GeneralItemTemplate}">
</ListView>

Expand Down
Expand Up @@ -193,7 +193,7 @@
<value>Automatically copy selection to clipboard</value>
</data>
<data name="Globals_KeybindingsDisclaimer.Text" xml:space="preserve">
<value>This is a list of the currently bound keys. Currently, these can only be edited in the settings file directly.</value>
<value>This is a list of the currently bound keys. Currently, these can only be edited in the settings file.</value>
</data>
<data name="Globals_KeybindingsLink.Content" xml:space="preserve">
<value>Open JSON settings</value>
Expand Down Expand Up @@ -351,7 +351,7 @@
<value>Rendering</value>
</data>
<data name="Nav_Actions.Content" xml:space="preserve">
<value>Keybindings</value>
<value>Actions</value>
</data>
<data name="Profile_AcrylicOpacity.Header" xml:space="preserve">
<value>Acrylic opacity</value>
Expand Down

0 comments on commit 05d48ca

Please sign in to comment.