Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ReadConsoleA/W API routines #15780

Merged
merged 3 commits into from Aug 1, 2023
Merged

Merge ReadConsoleA/W API routines #15780

merged 3 commits into from Aug 1, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 31, 2023 •
edited

This is a minor cleanup to deduplicate the two ReadConsole methods
and will help with making changes to how COOKED_READ_DATA is called.
It additionally changes the initial data payload from a string_view
to a wstring_view as it is guaranteed to be wchar_t.
This matches the current COOKED_READ_DATA implementation which
blindly assumes that the initial data consists of wchar_t.

Closes #5618

@lhecker lhecker added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Jul 31, 2023
Base automatically changed from dev/lhecker/8000-cmdline-prep1 to main August 1, 2023 00:00
@lhecker
Copy link
Member Author

lhecker commented Aug 1, 2023 •
edited

FYI I pushed git rebase --onto origin/main 22d9d2f7244fdbe16aae79df06a781f4b4caff6f
(For diff, click "force-pushed" below.)

@lhecker lhecker force-pushed the dev/lhecker/8000-cmdline-prep2 branch from 92c1ff5 to 08ff794 Compare August 1, 2023 12:50
@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-CookedRead The cmd.exe COOKED_READ handling Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase labels Aug 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 07566fa into main Aug 1, 2023
15 of 17 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the dev/lhecker/8000-cmdline-prep2 branch August 1, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-CookedRead The cmd.exe COOKED_READ handling Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate why the COOKED_READ_DATA ctor takes a string_view for wchar_t data?
4 participants
@lhecker @DHowett @carlos-zamora @zadjii-msft