Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite COOKED_READ_DATA #15783

Merged
merged 14 commits into from Aug 25, 2023
Merged

Rewrite COOKED_READ_DATA #15783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b47784d
Rewrite COOKED_READ_DATA
lhecker Aug 11, 2023
5f683cf
What's wrong with would've?
lhecker Aug 11, 2023
4b8e5e2
Merge remote-tracking branch 'origin/main' into dev/lhecker/8000-cmdline
lhecker Aug 15, 2023
46f8ee2
Merge remote-tracking branch 'origin/main' into dev/lhecker/8000-cmdline
lhecker Aug 21, 2023
80fa72d
Address feedback, Fix ENABLE_PROCESSED_INPUT
lhecker Aug 21, 2023
7f33b0f
Address feedback
lhecker Aug 23, 2023
a59e3db
Spel
lhecker Aug 23, 2023
4f09dab
Address feedback
lhecker Aug 24, 2023
3ca867c
Remove loop around _popupsDone
lhecker Aug 24, 2023
69532f2
Avoid unnecessary redraws
lhecker Aug 24, 2023
2b467fd
Get GetReadableColumnCount from that other PR
lhecker Aug 24, 2023
1f5504f
Fix incorrect cursor position with git add -p
lhecker Aug 24, 2023
b9302d7
Merge remote-tracking branch 'origin/main' into dev/lhecker/8000-cmdline
lhecker Aug 25, 2023
cd3a749
Address feedback
lhecker Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/spelling/expect/expect.txt
View file
Open in desktop
Expand Up @@ -1300,6 +1300,7 @@ onecoreuuid
ONECOREWINDOWS
onehalf
oneseq
OOM
openbash
opencode
opencon
Expand Down
2 changes: 1 addition & 1 deletion src/host/_stream.cpp
View file
Open in desktop
Expand Up @@ -206,7 +206,7 @@ void WriteCharsLegacy(SCREEN_INFORMATION& screenInfo, const std::wstring_view& t
// Otherwise handling backspacing tabs/whitespace can turn up complex and bug-prone.
assert(!interactive);
auto pos = cursor.GetPosition();
pos.x = textBuffer.GetRowByOffset(pos.y).NavigateToPrevious(pos.x);
pos.x = textBuffer.GetMutableRowByOffset(pos.y).NavigateToPrevious(pos.x);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this one require mutability?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, yeah, good point.

AdjustCursorPosition(screenInfo, pos, interactive, psScrollY);
continue;
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.