[Tests] Add test for subparameter based GraphicOptions #15844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharsnx
changed the title
DHowett
reviewed
Aug 18, 2023
| @@ -332,6 +332,24 @@ class TestGetSet final : public ITerminalApi | |||
| _expectedCursorPos = cursorPos; | |||
| } | |||
|
|
|||
| static void MakeSubParamsAndRanges(std::initializer_list<std::initializer_list<const VTParameter>> subParamList, _Out_ std::vector<VTParameter>& subParams, _Out_ std::vector<std::pair<BYTE, BYTE>>& subParamRanges) | |||
lhecker
approved these changes
Aug 21, 2023
5 tasks
zadjii-msft
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for subparameter based
GraphicOptions.GraphicsSingleWithSubParamTestsis added for subparameter basedGraphicOptions. This should've been included with #15729.Also, while working on #15795, I realized creating and passing subparameters for the tests is painful right now. I've added a small util
MakeSubParamsAndRanges(...)that eases creating subparameters and subparameter ranges from a simple list of (lists of) subparameters.Validation Steps Performed