[v1.6 ONLY] Make Settings UI inaccessible #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Feb 19, 2021
src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h
Outdated
Show resolved
Hide resolved
DHowett
requested changes
Feb 19, 2021
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
This comment has been minimized.
This comment has been minimized.
carlos-zamora
force-pushed
the
dev/cazamor/sui/remove-sui-binding
branch
from
6d25024
to
55220da
Compare
|
Thanks for doing this! |
zadjii-msft
approved these changes
Feb 22, 2021
DHowett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes access to the Settings UI for v1.6 stable. Any attempts to bind the Settings UI result in a parsing error as shown below:
#6800 - Settings UI Epic