Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SettingsTab close icon to be smaller #9324

Merged
1 commit merged into from
Mar 4, 2021
Merged

Change SettingsTab close icon to be smaller #9324

1 commit merged into from
Mar 4, 2021

Conversation

carlos-zamora
Copy link
Member

We were using the wrong close icon for the settings tab. This is a side effect of TerminalTab overriding TabBase's implementation.

#6800 - Settings UI Epic

Closes #9317

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 2, 2021
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Mar 2, 2021
@ghost ghost requested review from miniksa, DHowett, leonMSFT and PankajBhojwani March 2, 2021 18:28
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 4, 2021
@ghost
Copy link

ghost commented Mar 4, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Mar 4, 2021
@ghost ghost merged commit 4a95341 into main Mar 4, 2021
@ghost ghost deleted the dev/cazamor/sui/settings-tab-close-icon branch March 4, 2021 19:32
DHowett pushed a commit that referenced this pull request Mar 15, 2021
@carlos-zamora @DHowett
Change SettingsTab close icon to be smaller (#9324)
cd68bd0 
We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation.

#6800 - Settings UI Epic

Closes #9317

(cherry picked from commit 4a95341)
DHowett pushed a commit that referenced this pull request Mar 15, 2021
@carlos-zamora @DHowett
Change SettingsTab close icon to be smaller (#9324)
fb4dab0 
We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation.

#6800 - Settings UI Epic

Closes #9317

(cherry picked from commit 4a95341)
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Mar 16, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal v1.7.1033.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 14, 2021
Closed
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Settings context menu still uses the BIG close icon
3 participants
@carlos-zamora @DHowett @zadjii-msft