Use typings instead of tsd to grab d.ts files #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSD has been deprecated (see DefinitelyTyped/tsd#269) in favor of further development on typings. Updating the node.js sample to install and use typings instead.
|
Thanks for the heads-up on this deprecation and PR! There are several other places where we refer to TSD in the docs and we should be consistent, e.g, https://code.visualstudio.com/Docs/runtimes/nodejs. We also use TSD in samples and we as a time still have tsd in our brains and hands. @gregvanl let's make this a concerted effort on this and let's wait with adopting this PR. |
|
Sounds good, thanks Erich! |
|
Hi Ben, I can't merge your pull request due to conflicts but I'll take your changes manually. I'm also updating other uses of TSD in our docs. |
|
Added Ben changes with ea22387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSD has been deprecated (see DefinitelyTyped/tsd#269) in favor of further development on typings. Updating the node.js sample to install and use typings instead.
TSD still works for now, but may as well be future proof :)