New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`HoverContext` should pass back the specific type of hover I provided #211155

Open

mjbvz opened this issue Apr 23, 2024 · 0 comments · May be fixed by #211223

Assignees

Contributor

mjbvz commented Apr 23, 2024

Testing #210904

I suggest that we change the provider to:

interface  HoverProvider<T extends Hover = Hover> {... }

And then make HoverContext use the specific type of hover our provider returned (T). This lets us avoid an extra cast

The text was updated successfully, but these errors were encountered:

mjbvz assigned aiday-mar

aiday-mar linked a pull request

that will close this issue

Use generics in the proposed hover verbosity API #211223

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment