Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generics in the proposed hover verbosity API #211223

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use generics in the proposed hover verbosity API #211223

wants to merge 2 commits into from
+6 −6

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Apr 24, 2024 •
edited

fixes #211155

Use generics in the proposed hover verbosity API

@aiday-mar aiday-mar self-assigned this Apr 24, 2024
@aiday-mar aiday-mar requested a review from jrieken April 24, 2024 10:18
@aiday-mar
Copy link
Contributor Author

Hi @jrieken in relation to #211155, I would like to use generics in the hover provider which requires changing the vscode.d.ts. Could you review the PR since you review API changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrieken jrieken Awaiting requested review from jrieken jrieken is a code owner

@mjbvz mjbvz Awaiting requested review from mjbvz mjbvz will be requested when the pull request is marked ready for review mjbvz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HoverContext should pass back the specific type of hover I provided
1 participant
@aiday-mar