Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up latest TS for building VS Code #210956

Merged
merged 8 commits into from May 6, 2024
Merged

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Apr 22, 2024

Currently breaks typescript-formatter:

TypeError: host.fileExists is not a function
      at getPackageJsonInfo (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:44904:31)
      at getPackageScopeForPath (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:44826:17)
      at lookupFromPackageJson (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:123723:30)
      at getImpliedNodeFormatForFileWorker (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:123717:353)
      at getImpliedNodeFormatForFile (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:123713:18)
      at SyntaxTreeCache.getCurrentSourceFile (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:148976:28)
      at Object.getFormattingEditsForDocument (/Users/matb/projects/vscode/node_modules/typescript/lib/typescript.js:149750:65)
      at Object.format (/Users/matb/projects/vscode/node_modules/typescript-formatter/lib/formatter.ts:26:35)
      at /Users/matb/projects/vscode/node_modules/typescript-formatter/lib/index.ts:174:33
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

@mjbvz mjbvz marked this pull request as ready for review May 2, 2024 18:23
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 2, 2024
justschen
justschen previously approved these changes May 2, 2024
@justschen
Copy link
Contributor

looks like some installs failed

@mjbvz mjbvz enabled auto-merge (squash) May 6, 2024 19:48
@mjbvz mjbvz merged commit 3f91c9b into microsoft:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants