Don't include internal schemes in references/implementation results #211149
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft/vscode-copilot-release#1055 This filters out references to code in chat and walkthroughts. Doing this in core because otherwise we will need each extension/language to add this filtering themselves
jrieken
requested changes
Apr 23, 2024
|
I'd like to get this merged but agree we should think about how to handle this more elegantly. Some of it does need to be handled on a case by case basis but maybe there's also some generic list of simple language feature schemes we can support |
roblourens
previously approved these changes
May 2, 2024
mjbvz
force-pushed
the
foreign-eel
branch
2 times, most recently
from
beeb799
to
30d16ad
Compare
justschen
approved these changes
May 2, 2024
jrieken
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-copilot-release#1055
This filters out references to code in chat and walkthroughts. Doing this in core because otherwise we will need each extension/language to add this filtering themselves