Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where ending drag on a menu item causes click in Firefox #211245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pnhalim
Copy link

@pnhalim pnhalim commented Apr 24, 2024

Fixes #180833

This PR fixes the bug where dragging and then releasing over a sidebar, status bar, or activity bar activates an unintended click in Firefox.

hi.Untitled-2.-.Workspace.-.Code.-.OSS.Dev.Mozilla.Firefox.2024-04-24.07-12-03.mp4

Fixes the following items

  • Activity bar buttons
  • Sidebar buttons
  • Sidebar dropdowns
  • Status bar buttons
  • Command center control
  • Layout controls toggle buttons

Does not fix the following

  • Certain buttons within the 'Search' sidebar panel
  • Command center control only when clicking in the center where the text is

@pnhalim
Copy link
Author

pnhalim commented Apr 24, 2024

@microsoft-github-policy-service agree

Copy link

@sanqro sanqro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox: Files in menu items (such as explorer) are opened on mouseup, not onclick
3 participants